max/ourMELONS
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Updated TODOs

Browse source
This commit is contained in:
Waldir Leoncio 2020-03-24 15:54:48 +01:00
parent 3b17f72e46
commit 07206152e8
2 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
R/admix1.R
View file

@ -25,7 +25,7 @@ admix1 <- function(tietue, PARTITION = matrix(NA, 0, 0),
cat('---------------------------------------------------\n'); cat('---------------------------------------------------\n');
message('Reading mixture result from: ', pathname_filename, '...') message('Reading mixture result from: ', pathname_filename, '...')
} }
Sys.sleep(0.0001) #ASK: what for? Sys.sleep(0.0001) #TODO: remove
# ASK: what is this supposed to do? What do graphic obj have to do here? # ASK: what is this supposed to do? What do graphic obj have to do here?
# h0 = findobj('Tag','filename1_text'); # h0 = findobj('Tag','filename1_text');
@ -50,7 +50,7 @@ admix1 <- function(tietue, PARTITION = matrix(NA, 0, 0),
# Redirect the call to the linkage admixture function. # Redirect the call to the linkage admixture function.
# call function noindex to remove the index column # call function noindex to remove the index column
c$data <- noIndex(c$data, c$noalle) c$data <- noIndex(c$data, c$noalle)
# linkage_admix(c) # ASK: translate this function to R or drop? # linkage_admix(c) # TODO: obsolete. remove.
# return # return
stop("linkage_admix not implemented") stop("linkage_admix not implemented")
} }
@ -371,9 +371,8 @@ admix1 <- function(tietue, PARTITION = matrix(NA, 0, 0),
} }
} }
# ASK: Remove? are these plotting functions? tulostaAdmixtureTiedot(proportionsIt, uskottavuus, alaRaja, iterationCount) # TODO: textual outputs. probably not necessary. translate nonetheless
tulostaAdmixtureTiedot(proportionsIt, uskottavuus, alaRaja, iterationCount) viewPartition(proportionsIt, popnames) # TODO: adapt
viewPartition(proportionsIt, popnames)
talle = inputdlg('Do you want to save the admixture results? [Y/n]', 'y') talle = inputdlg('Do you want to save the admixture results? [Y/n]', 'y')
if (talle %in% c('y', 'Y', 'yes', 'Yes')) { if (talle %in% c('y', 'Y', 'yes', 'Yes')) {

2
TODO.md
View file

@ -16,9 +16,9 @@ Note to contributors: as tasks get finished, please update this file with an `x`
The list below contains non-essential but nice-to-have tasks for the next stable release. The list below contains non-essential but nice-to-have tasks for the next stable release.
- [ ] Implement sparse matrix optimizations from `fastbaps`
- [ ] Standardize capitalization of function names - [ ] Standardize capitalization of function names
- [ ] Standardize capitalization of function arguments - [ ] Standardize capitalization of function arguments
- [ ] Implement optimizations from `fastbaps`
- [ ] Replace redundant functions (ex.: `randga`) - [ ] Replace redundant functions (ex.: `randga`)
# Known pitfalls # Known pitfalls