From 4ffa771f0f39864c20b42d39fb4c6130e66464d6 Mon Sep 17 00:00:00 2001
From: tmk <hasu@tmk-kbd.com>
Date: Mon, 14 Feb 2022 16:59:53 +0900
Subject: [PATCH] pc98: Fix glitch and reset signal

- Change order of setting PORT and DDR to prevent glitch
- RST pin cannot be controlled after USART starts
---
 converter/pc98_usb/matrix.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/converter/pc98_usb/matrix.c b/converter/pc98_usb/matrix.c
index 17335aa9..029c599f 100644
--- a/converter/pc98_usb/matrix.c
+++ b/converter/pc98_usb/matrix.c
@@ -123,15 +123,12 @@ RETRY:
 
 void matrix_init(void)
 {
-    PC98_RST_DDR |= (1<<PC98_RST_BIT);
-    PC98_RDY_DDR |= (1<<PC98_RDY_BIT);
-    PC98_RTY_DDR |= (1<<PC98_RTY_BIT);
     PC98_RST_PORT |= (1<<PC98_RST_BIT);
+    PC98_RST_DDR |= (1<<PC98_RST_BIT);
     PC98_RDY_PORT |= (1<<PC98_RDY_BIT);
+    PC98_RDY_DDR |= (1<<PC98_RDY_BIT);
     PC98_RTY_PORT |= (1<<PC98_RTY_BIT);
-
-
-    serial_init();
+    PC98_RTY_DDR |= (1<<PC98_RTY_BIT);
 
     // PC98 reset
     // https://archive.org/stream/PC9800TechnicalDataBookHARDWARE1993/PC-9800TechnicalDataBook_HARDWARE1993#page/n359
@@ -140,6 +137,8 @@ void matrix_init(void)
     _delay_us(15);                          // > 13us
     PC98_RST_PORT |= (1<<PC98_RST_BIT);     // RST: high
 
+    serial_init();
+
     _delay_ms(50);
     if (pc98_is_newtype()) xprintf("new type\n"); else xprintf("old type\n");
     pc98_inhibit_repeat();