max/tmk_keyboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

core: Saved 60~ bytes (and possible performance) by storing col_mask when iterating through columns (#522)

Browse source
This commit is contained in:
Alex Ong 2018-01-24 14:15:56 +11:00 • committed by hasu@tmk
parent 7d056762d0
commit ad6059adc7
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tmk_core/common/keyboard.c
View file

@ -126,17 +126,18 @@ void keyboard_task(void)
matrix_ghost[r] = matrix_row; matrix_ghost[r] = matrix_row;
#endif #endif
if (debug_matrix) matrix_print(); if (debug_matrix) matrix_print();
for (uint8_t c = 0; c < MATRIX_COLS; c++) { matrix_row_t col_mask = 1;
if (matrix_change & ((matrix_row_t)1<<c)) { for (uint8_t c = 0; c < MATRIX_COLS; c++, col_mask <<= 1) {
if (matrix_change & col_mask) {
keyevent_t e = (keyevent_t){ keyevent_t e = (keyevent_t){
.key = (keypos_t){ .row = r, .col = c }, .key = (keypos_t){ .row = r, .col = c },
.pressed = (matrix_row & ((matrix_row_t)1<<c)), .pressed = (matrix_row & col_mask),
.time = (timer_read() | 1) /* time should not be 0 */ .time = (timer_read() | 1) /* time should not be 0 */
}; };
action_exec(e); action_exec(e);
hook_matrix_change(e); hook_matrix_change(e);
// record a processed key // record a processed key
matrix_prev[r] ^= ((matrix_row_t)1<<c); matrix_prev[r] ^= col_mask;
// This can miss stroke when scan matrix takes long like Topre // This can miss stroke when scan matrix takes long like Topre
// process a key per task call // process a key per task call