From d51023bc8bb82dfb6eb45d1c4f85017a7f680511 Mon Sep 17 00:00:00 2001 From: tmk Date: Fri, 17 Feb 2023 09:12:57 +0900 Subject: [PATCH] ibmpc: Fix XT startup fail #751 SIEMENS_PCD_SUPPORT #747 code should be applied only for AT. The code inhibits AT keyboard from sending by pulling clock line down, this made XT keyboard support messed. --- tmk_core/protocol/ibmpc.cpp | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tmk_core/protocol/ibmpc.cpp b/tmk_core/protocol/ibmpc.cpp index 3f931c10..074a2018 100644 --- a/tmk_core/protocol/ibmpc.cpp +++ b/tmk_core/protocol/ibmpc.cpp @@ -142,9 +142,11 @@ RETRY: #ifdef SIEMENS_PCD_SUPPORT // inhibit - https://github.com/tmk/tmk_keyboard/issues/747 - wait_us(15); - clock_lo(); - wait_us(150); + if (protocol & IBMPC_PROTOCOL_AT) { + wait_us(15); + clock_lo(); + wait_us(150); + } #endif // clear buffer to get response correctly @@ -369,9 +371,11 @@ void IBMPC::isr(void) DONE: #ifdef SIEMENS_PCD_SUPPORT // inhibit - https://github.com/tmk/tmk_keyboard/issues/747 - clock_lo(); - wait_us(150); - clock_hi(); + if (protocol & IBMPC_PROTOCOL_AT) { + clock_lo(); + wait_us(150); + clock_hi(); + } #endif // store data